Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set test threshold for TypeScript files #3002

Closed
marsis opened this issue Nov 3, 2016 · 4 comments
Closed

Can't set test threshold for TypeScript files #3002

marsis opened this issue Nov 3, 2016 · 4 comments
Labels
needs: investigation Requires some digging to determine if action is needed

Comments

@marsis
Copy link

marsis commented Nov 3, 2016

Please provide us with the following information:

OS?

Linux Ubuntu 16.04

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.19-3
node: 6.9.1
os: linux x64

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.
App was created using CLI

The log given by the failure.

Normally this include a stack trace and some more information.

Istanbul's reports doesn't match karma-coverage reports . I need to set test threshold for unit tests in typescript files. I installed karma-coverage, but it creates reports with test coverage for javascript files. Threshold compares with coverage for javascript files and I receive unreliable information

Mention any other details that might be useful.


Thanks! We'll be in touch soon.

@filipesilva
Copy link
Contributor

If I remember correctly, just using karma-coverage wasn't enough because code needed to be instrumented as it is compiled, before hitting the karma plugin.

I'm not too familiar with this threshold functionality though, so not sure what we can do. A bit of a shot in the dark, but does #1735 help?

@filipesilva filipesilva added command: test needs: investigation Requires some digging to determine if action is needed labels Nov 4, 2016
@villelahdenvuo
Copy link
Contributor

We're also wondering about this. With karme-coverage you can set the check-object to add coverage thresholds, but the karma-remap-istanbul does not seem to support this.

Has anyone managed to configure coverage thresholds?

@filipesilva
Copy link
Contributor

Newer versions of karma-coverage-instanbul-reporter seem to have threshold related functionality: #5519

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: investigation Requires some digging to determine if action is needed
Projects
None yet
Development

No branches or pull requests

3 participants