feat(build): add style paths #4003
Conversation
filipesilva
force-pushed
the
style-paths
branch
from
e8a741d
to
4476f61
Compare
| const includePaths = [ | ||
| path.resolve(appRoot, './style-paths/') | ||
| ]; | ||
|
|
| disable: !extractCss | ||
| }), | ||
| new webpack.LoaderOptionsPlugin({ | ||
| test: /\.(css|scss|sass|less|styl)$/, |
There was a problem hiding this comment.
This test technically isn't needed and It adds an additional check per resource request.
filipesilva
force-pushed
the
style-paths
branch
3 times, most recently
from
ce516be
to
bdd4b36
Compare
| && appConfig.stylePreprocessorOptions.includePaths.length > 0 | ||
| ) { | ||
| appConfig.stylePreprocessorOptions.includePaths.forEach((includePath: string) => | ||
| includePaths.push(path.resolve(appRoot, includePath))); |
There was a problem hiding this comment.
Using appRoot requires me to specify my includePaths relative to the current appRoot. I guess that's not bad. Here's a sample configuration I have to do and it works 👍 :
"stylePreprocessorOptions": {
"includePaths": [
"../../node_modules",
"../src"
]
}There was a problem hiding this comment.
Yeah in general anything that's within app config is always relative to appRoot. This way it's consistent.
| } | ||
|
|
||
| // supress empty .js files in css only entry points | ||
| if (extractCss) { extraPlugins.push(new SuppressExtractedTextChunksWebpackPlugin()); } |
There was a problem hiding this comment.
Split on a separate line please.
| { test: /\.html$/, loader: 'raw-loader' }, | ||
|
|
||
| { test: /\.(eot|svg)$/, loader: `file-loader?name=[name]${hashFormat.file}.[ext]` }, |
There was a problem hiding this comment.
Those new loaders are not part of the issue..?
There was a problem hiding this comment.
They aren't new, they were just moved up from a few lines below.
filipesilva
force-pushed
the
style-paths
branch
2 times, most recently
from
28c1a23
to
c181c0c
Compare
Add `paths/includePaths` functionality for `sass` and `stylus`. Similar functionality for less is blocked by webpack-contrib/less-loader#75. To add paths, use the new entry in `angular-cli.json` app object: ``` "stylePreprocessorOptions": { "includePaths": [ "style-paths" ] }, ``` Fix angular#1791
filipesilva
force-pushed
the
style-paths
branch
from
c181c0c
to
f1cd870
Compare
Add `paths/includePaths` functionality for `sass` and `stylus`. Similar functionality for less is blocked by webpack-contrib/less-loader#75. To add paths, use the new entry in `angular-cli.json` app object: ``` "stylePreprocessorOptions": { "includePaths": [ "style-paths" ] }, ``` Fix angular#1791
This feature was introduce in angular#4003 but never documented.
This feature was introduce in #4003 but never documented.
This feature was introduce in angular#4003 but never documented.
|
Any workaround for less? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add
paths/includePathsfunctionality forsassandstylus.Similar functionality for less is blocked by webpack-contrib/less-loader#75.
To add paths, use the new entry in
angular-cli.jsonapp object:Fix #1791