fix(@angular/cli): Fixing set prefix issue #5301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumitarora
force-pushed
the
fix-set-prefix
branch
2 times, most recently
from
3292ac6
to
89b10b9
Compare
Brocco
approved these changes
Mar 8, 2017
filipesilva
approved these changes
Mar 8, 2017
filipesilva
reviewed
Mar 8, 2017
tests/e2e/tests/commands/set/set.ts
Outdated
| .then(() => ng('get', 'apps.0.prefix')) | ||
| .then(({ stdout }) => { | ||
| if (!stdout.match(/new-prefix/)) { | ||
| throw new Error(`Expected "app", received "${JSON.stringify(stdout)}".`); |
There was a problem hiding this comment.
Expected "app"->Expected "new-prefix"
There was a problem hiding this comment.
@filipesilva done
johnpapa
suggested changes
Mar 8, 2017
sumitarora
force-pushed
the
fix-set-prefix
branch
from
89b10b9
to
c4d3733
Compare
sumitarora
force-pushed
the
fix-set-prefix
branch
from
c4d3733
to
ecf242f
Compare
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5298