Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continued use of ember-addon package.json keyword poised to cause trouble #55

Closed
endash opened this issue Oct 25, 2015 · 7 comments
Closed

Comments

@endash
Copy link

endash commented Oct 25, 2015

Obviously there's extensive name leakage from the wrapped EmberCLI library, but this one has present-day consequences:

http://www.emberaddons.com/?query=angular

There's only a single angular addon listed, but I moved my app over to angular-cli today partly to start packaging some of my code as addons. So I anticipate that changing.

@endash endash changed the title Continued use of ember-addon package.json key poised to cause trouble Continued use of ember-addon package.json keyword poised to cause trouble Oct 25, 2015
@cironunes
Copy link
Member

This is being addressed here IgorMinar/angular-cli-github-pages#1

The actual issue is on the angular-cli-github-pages project.

@endash
Copy link
Author

endash commented Oct 26, 2015

@IgorMinar
Copy link
Contributor

yup. I know about this one. my plan is to talk to @stefanpenner about this and see if we can do better.

To be honest I don't think that the current strategy of creating angular-cli as an addon for ember-cli will work beyond tech demo. There way too many assumption in the current system. The only way I can see this working is for us to extract all the reusable bits from ember-cli into a separate project and then build both angular and ember cli on top of this project. The alternative is to rebuild most of the current stuff from scratch, but that would be sad.

@stefanpenner
Copy link

Im in-board with further parametrization/extraction/configuration as needed. We just need extra people power :) and a plan

@cironunes
Copy link
Member

I'd love to help.

@hansl
Copy link
Contributor

hansl commented Mar 17, 2016

I'm going to close this issue as this discussion seems to be closed. Once we hit alpha we need to revisit our long term plans with @stefanpenner and see how we can help make both projects better (and awesome-er)

@hansl hansl closed this as completed Mar 17, 2016
clydin pushed a commit that referenced this issue Jun 5, 2018
update the reference cli url in documentation to point to the schematics.ts file

resolve issue #55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants