Skip to content

Conversation

jhr007
Copy link

@jhr007 jhr007 commented Jan 25, 2016

Wasn't sure if removing or changing was better.... your call.

It's causing this package to show up on emberaddons.com :D
@JohannesHoppe
Copy link

I'm pretty much sure that this won't work. Do you have any docs / source code where angular-addon is specified?

@jhr007
Copy link
Author

jhr007 commented Apr 11, 2016

When you use ember cli to create an ember addon it automatically tags it as an ember-addon. This causes the npm package to show up on ember sites that use it to identify ember packages.

https://www.emberaddons.com/?query=angular

I don't know if the angular community is doing something similar.

@JohannesHoppe
Copy link

Allright. Right now angular-cli is based on top of ember-cli. And yes, angular-cli plugins are incorrectly shown on emberaddons.com. The troubles are caused due to this line of code:
https://github.com/ember-cli/ember-cli/blob/ae5e72614e40f5e6dd57463e526c65da899fde07/lib/models/addon-discovery.js#L206

There is more discussion here:
angular/angular-cli#55

As you see, your commit would break the "angular-cli" addon which is unfortionally tagged with "ember-addon".

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants