Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stories - Global Lib to reflect latest changes required by bootstrap4 beta #7584

Closed
adityaparab opened this issue Sep 3, 2017 · 1 comment · Fixed by #7586
Closed
Assignees
Labels
area: docs Related to the documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@adityaparab
Copy link
Contributor

adityaparab commented Sep 3, 2017

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.3.1
node: 6.2.1
os: win32 x64

Repro steps.

Update angular-cli.json to include jquery, popper.js and bootstrap4 (beta)

"styles": [
    "../node_modules/bootstrap/dist/css/bootstrap.css"
  ],
  "scripts": [
    "../node_modules/jquery/dist/jquery.js",
    "../node_modules/popper.js/dist/popper.js",
    "../node_modules/bootstrap/dist/js/bootstrap.js"
  ],

The log given by the failure.

Uncaught SyntaxError: Unexpected token export
    at eval (<anonymous>)
    at webpackJsonp.../../../../script-loader/addScript.js.module.exports (addScript.js:9)
    at Object.../../../../script-loader/index.js!../../../../popper.js/dist/popper.js (popper.js?4b43:1)
    at __webpack_require__ (bootstrap 4403042439558687cdd6:54)
    at Object.2 (scripts.bundle.js:66)
    at __webpack_require__ (bootstrap 4403042439558687cdd6:54)
    at webpackJsonpCallback (bootstrap 4403042439558687cdd6:25)
    at scripts.bundle.js:1

Desired functionality.

Wiki page to be updated to reflect correct configuration

Mention any other details that might be useful.

Bootstrap 4 no longer uses tether. It now requires popper.js
Global Lib Story page to be updated to show correct configuration.

@filipesilva filipesilva self-assigned this Sep 5, 2017
@filipesilva filipesilva added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: docs Related to the documentation labels Sep 5, 2017
filipesilva pushed a commit that referenced this issue Sep 5, 2017
…trap4

configuration

- update bootstrap4 url to point to correct page
- remove tether import in .angular-cli.json
- add umd version popper.js import in .angular-cli.json instead of tether

Closes #7584
filipesilva pushed a commit that referenced this issue Sep 6, 2017
…trap4

configuration

- update bootstrap4 url to point to correct page
- remove tether import in .angular-cli.json
- add umd version popper.js import in .angular-cli.json instead of tether

Closes #7584
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
…trap4

configuration

- update bootstrap4 url to point to correct page
- remove tether import in .angular-cli.json
- add umd version popper.js import in .angular-cli.json instead of tether

Closes angular#7584
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: docs Related to the documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
2 participants