-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng build --prod doesn't minified ngsw-worker.js #9970
Comments
Neither it is transpiled down to ES5. Service workers are supported in environments where async functions aren't (Chrome <= 54) so it fails. |
It seems to be transpiled down to ES2015 now, using generators instead of async/await. Still no minification though. |
Just leaving a note here... Be very careful about fixing this bug as a lot of people are working around this issue angular/angular#21191 by inserting specific code in this very file. See comment: angular/angular#21191 (comment) Maybe issue angular/angular#21191 should be addressed first EDIT: I know that this issue shouldn't depend on the other one. If a fix is possible to minify |
Heya, this issue is the same as #11538. I'm closing this one in favor of that one because it has an answer from the team member responsible for service workers. |
@filipesilva this one is #9970, I guess you mean another. |
@awerlang sorry about that, fixed the link now. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When building for production environment ngsw-worker/js file included in /DIST folder isn;y minified. We can save 75 KB and get better performance
Version 1.7.3
Repro steps
Observed behavior
The file contains 107KB of code
Desired behavior
The file is minified and contains less than 35KB of code
The text was updated successfully, but these errors were encountered: