Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in ng new "path" options #11025

Closed
FrozenPandaz opened this issue May 25, 2018 · 2 comments · Fixed by #11083
Closed

Regression in ng new "path" options #11025

FrozenPandaz opened this issue May 25, 2018 · 2 comments · Fixed by #11083
Labels
area: angular/cli freq2: medium severity3: broken

Comments

@FrozenPandaz
Copy link
Contributor

FrozenPandaz commented May 25, 2018 •
edited

Versions

Before

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 6.0.1
Node: 8.11.1
OS: linux x64
Angular: 
... 

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.6.1
@angular-devkit/core         0.6.1
@angular-devkit/schematics   0.6.1
@schematics/angular          0.6.1
@schematics/update           0.6.1
rxjs                         6.2.0
typescript                   2.7.2

After

jason@Jason-PC-U:~/projects/work/temp$ ng -v

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 6.0.5
Node: 8.11.1
OS: linux x64
Angular: 
... 

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.6.5
@angular-devkit/core         0.6.5
@angular-devkit/schematics   0.6.5
@schematics/angular          0.6.5
@schematics/update           0.6.5
rxjs                         6.2.0
typescript                   2.7.2

This happened in 6.0.3

Observed behavior

When creating a new project with a specified collection, the options of type path now defaults to '/'.

sudo npm i @angular/cli@6.0.3 -g
sudo npm i @ngrx/schematics -g # Separate Issue
sudo npm i @nrwl/schematics -g
ng new workspace --collection @nrwl/schematics
CREATE .prettierrc

... everything is created in the current working directory 👎

Desired behavior

When creating a new project with a specified collection, the options of type path used to default to empty string.

sudo npm i @angular/cli@6.0.1 -g
sudo npm i @ngrx/schematics -g # Separate Issue
sudo npm i @nrwl/schematics -g
ng new workspace --collection @nrwl/schematics
CREATE workspace/.prettierrc

... everything is created in the workspace directory 👍

Mention any other details that might be useful (optional)

This is the collection.json

"ng-new": {
  "factory": "./collection/ng-new",
  "schema": "./collection/ng-new/schema.json",
  "description": "Create an empty workspace"
},
@FrozenPandaz FrozenPandaz mentioned this issue May 25, 2018
Closed
Brocco added a commit to Brocco/angular-cli that referenced this issue Jun 1, 2018
@Brocco
fix(@angular/cli): Fix double setting of the path options for new
be9948d 
fixes angular#11025
@Brocco Brocco mentioned this issue Jun 1, 2018
Merged
Brocco added a commit to Brocco/angular-cli that referenced this issue Jun 7, 2018
@Brocco
fix(@angular/cli): Fix double setting of the path options for new
fd88e90 
fixes angular#11025
Brocco added a commit to Brocco/angular-cli that referenced this issue Jun 7, 2018
@Brocco
fix(@angular/cli): Fix double setting of the path options for new
4732c73 
fixes angular#11025
filipesilva pushed a commit that referenced this issue Jun 8, 2018
@Brocco @filipesilva
fix(@angular/cli): Fix double setting of the path options for new
04893ca 
fixes #11025
filipesilva pushed a commit to filipesilva/angular-cli that referenced this issue Jun 11, 2018
@Brocco @filipesilva
fix(@angular/cli): Fix double setting of the path options for new
50939d6 
fixes angular#11025
filipesilva pushed a commit to filipesilva/angular-cli that referenced this issue Jun 13, 2018
@Brocco @filipesilva
fix(@angular/cli): Fix double setting of the path options for new
0baf815 
fixes angular#11025
@rockGithub
Copy link

rockGithub commented Jul 8, 2018 •
edited

may I ask a question here, after I updated to using angular6, when I generate a new component ,it now generate a new component under the folder of e2e, previously it's in src/app/componentName path ?How to fix this or there might have some configuration there? thanks a lot

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: angular/cli freq2: medium severity3: broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): Fix double setting of the path options for new Brocco/angular-cli
5 participants
@Brocco @rockGithub @filipesilva @FrozenPandaz @clydin