Skip to content

fix(@angular/cli): Fix double setting of the path options for new #11083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2018
Merged

fix(@angular/cli): Fix double setting of the path options for new #11083

merged 1 commit into from
Jun 8, 2018

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Jun 1, 2018

fixes #11025

@FrozenPandaz
Copy link
Contributor

FrozenPandaz commented Jun 1, 2018 •
edited
Loading

Confirmed this fixes the issue :)

Fixes nrwl/nx#549

@Brocco Brocco force-pushed the new-path-options branch from be9948d to fd88e90 Compare June 7, 2018 13:32
@Brocco Brocco force-pushed the new-path-options branch from fd88e90 to 4732c73 Compare June 7, 2018 17:07
FrozenPandaz
FrozenPandaz approved these changes Jun 8, 2018
View reviewed changes
Copy link
Contributor

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansl PTAL :)

@filipesilva filipesilva merged commit 04893ca into angular:master Jun 8, 2018
@Brocco Brocco deleted the new-path-options branch June 8, 2018 17:10
@Brocco Brocco mentioned this pull request Jul 10, 2018
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@filipesilva filipesilva filipesilva approved these changes

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in ng new "path" options
4 participants
@Brocco @FrozenPandaz @filipesilva @googlebot