Webpack peer dependency fixes #11152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
build-webpack-peerdep
branch
4 times, most recently
from
ddfb690
to
07cd01a
Compare
clydin
reviewed
Jun 7, 2018
| @@ -86,6 +90,11 @@ export interface AngularCompilerPluginOptions { | |||
| // added to the list of lazy routes | |||
| additionalLazyModules?: { [module: string]: string }; | |||
|
|
|||
| // The ContextElementDependency of correct Webpack compilation. | |||
| // This is needed when there are multiple Webpack installs. | |||
| // tslint:disable-next-line:no-any | |||
There was a problem hiding this comment.
can remove the tslint disable here (and the one below on line 140)
filipesilva
force-pushed
the
build-webpack-peerdep
branch
from
07cd01a
to
786be99
Compare
filipesilva
force-pushed
the
build-webpack-peerdep
branch
from
786be99
to
0ca79f8
Compare
filipesilva
force-pushed
the
build-webpack-peerdep
branch
2 times, most recently
from
af174a0
to
7a9e0b7
Compare
…ndency class This should allow multiple webpack versions in the workspace dependencies with no weird errors. Fix angular#6417 for good.
…to ngtools/webpack Should go in only together with "feat(@ngtools/webpack): allow passing in the right ContextElementDependency class".
filipesilva
force-pushed
the
build-webpack-peerdep
branch
from
7a9e0b7
to
14867c6
Compare
clydin
approved these changes
Jun 8, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6417.
Fix #11152