Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular) changing order of event and coverage reporters #11539

Merged
merged 1 commit into from Jul 13, 2018

Conversation

banjankri
Copy link
Contributor

@banjankri banjankri commented Jul 13, 2018

Fixing an issue when event reporter is executed before coverage reporter, which was causing the test command to pass even though unit testing coverage thresholds were not met. Closes #10940

Fixing an issue when event reporter is executed before coverage reporter, which was causing the test command to pass even though unit testing coverage thresholds were not met.
@banjankri banjankri changed the base branch from master to devkit July 13, 2018 10:37
@banjankri banjankri changed the base branch from devkit to master July 13, 2018 10:38
@hansl hansl merged commit 09d019e into angular:master Jul 13, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular Cli: 6.0.1 code coverage thresholds not failing ng test task
3 participants