Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build should not hash lazy styles #11772

Closed
xmlking opened this issue Aug 3, 2018 · 1 comment · Fixed by #11981
Closed

build should not hash lazy styles #11772

xmlking opened this issue Aug 3, 2018 · 1 comment · Fixed by #11981
Labels
area: devkit/build-angular freq1: low Only reported by a handful of users who observe it rarely severity5: regression type: bug/fix

Comments

@xmlking
Copy link

xmlking commented Aug 3, 2018 •
edited

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

node  v10.7.0
npm 6.3.0

Angular CLI: 6.1.2
Node: 10.7.0
OS: darwin x64
Angular: 6.1.1
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.7.2
@angular-devkit/build-angular      0.7.2
@angular-devkit/build-ng-packagr   0.7.2
@angular-devkit/build-optimizer    0.7.2
@angular-devkit/build-webpack      0.7.2
@angular-devkit/core               0.7.2
@angular-devkit/schematics         0.7.2
@angular/cdk                       6.4.2
@angular/cdk-experimental          6.4.2
@angular/cli                       6.1.2
@angular/flex-layout               6.0.0-beta.17
@angular/material                  6.4.2
@angular/material-moment-adapter   6.4.2
@angular/pwa                       0.7.2
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.1.2
@schematics/angular                0.7.2
@schematics/update                 0.7.2
ng-packagr                         4.0.1
rxjs                               6.2.2
typescript                         2.9.2
webpack                            4.9.2

Repro steps

git clone https://github.com/xmlking/ngx-starter-kit
# change  "outputHashing": "media" ->  "outputHashing": "all" in angular.json
ng build --project=webapp -c=production

The log given by the failure

chunk {20} assets/themes/purple-green.c17c75933c9deb385322.css (assets/themes/purple-green) 41.7 kB [initial] [rendered]
chunk {21} assets/themes/pink-bluegrey.78fd02deb5fb284bee86.css (assets/themes/pink-bluegrey) 41.7 kB [initial] [rendered]
chunk {22} assets/themes/indigo-pink.f4824af46022d121b324.css (assets/themes/indigo-pink) 41.7 kB [initial] [rendered]
chunk {23} assets/themes/deeppurple-amber.fc4d4a015e92cbb72237.css (assets/themes/deeppurple-amber) 41.6 kB [initial] [rendered]

Desired functionality

According to https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/test/browser/output-hashing_spec_large.ts#L167

Build command should not hash lazy styles , but it is hashing lazy files.

My Config: https://github.com/xmlking/ngx-starter-kit/blob/master/angular.json#L41

Mention any other details that might be useful

https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/test/browser/output-hashing_spec_large.ts#L167
@filipesilva filipesilva added area: devkit/build-angular type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity5: regression labels Aug 4, 2018
@xmlking xmlking mentioned this issue Aug 19, 2018
Closed
@alan-agius4 alan-agius4 mentioned this issue Aug 23, 2018
Merged
hansl pushed a commit that referenced this issue Aug 23, 2018
@alan-agius4 @hansl
fix(@angular-devkit/build-angular): build should not hash lazy styles
2d84436 
When having `optimize` enabled the chunk Id doesn't match the bundle name, this we should use the chunk name instead

Closes #11772 and Closes #11704
hansl pushed a commit that referenced this issue Aug 23, 2018
@alan-agius4 @hansl
fix(@angular-devkit/build-angular): build should not hash lazy styles
8a1c62d 
When having `optimize` enabled the chunk Id doesn't match the bundle name, this we should use the chunk name instead

Closes #11772 and Closes #11704
xmlking added a commit to xmlking/ngx-starter-kit that referenced this issue Aug 23, 2018
@xmlking
upgraded angular-cli that fixed angular/angular-cli#11772
8c9708f
This was referenced Sep 22, 2018
Closed
Closed
Closed
Closed
Closed
Closed
xmlking added a commit to xmlking/ngx-starter-kit that referenced this issue Mar 6, 2019
@xmlking
upgraded angular-cli that fixed angular/angular-cli#11772
1d1d327
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
coolkei added a commit to coolkei/ngx_Angular that referenced this issue Feb 4, 2024
@coolkei
upgraded angular-cli that fixed angular/angular-cli#11772
a28409e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: devkit/build-angular freq1: low Only reported by a handful of users who observe it rarely severity5: regression type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular-devkit/build-angular): build should not hash lazy styles
2 participants
@xmlking @filipesilva