Skip to content

fix(@angular-devkit/build-angular): build should not hash lazy styles#11981

Merged
hansl merged 1 commit intoangular:masterfrom
alan-agius4:fix_lazy_styles_hash
Aug 23, 2018
Merged

fix(@angular-devkit/build-angular): build should not hash lazy styles#11981
hansl merged 1 commit intoangular:masterfrom
alan-agius4:fix_lazy_styles_hash

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

When having optimize enabled the chunk Id doesn't match the bundle name, this we should use the chunk name instead

Closes #11772 and Closes #11704

When having `optimize` enabled the chunk Id doesn't match the bundle name, this we should use the chunk name instead

Closes #11772 and Closes #11704
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Aug 23, 2018
Copy link
Copy Markdown
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hansl hansl merged commit 2d84436 into angular:master Aug 23, 2018
@alan-agius4 alan-agius4 deleted the fix_lazy_styles_hash branch August 23, 2018 17:32
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build should not hash lazy styles Lazy loaded styles are still hashed

4 participants