Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular-devkit/build-angular): don't override missing options in… #12507

Merged
merged 1 commit into from
Oct 10, 2018
Merged

fix(@angular-devkit/build-angular): don't override missing options in… #12507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/angular_devkit/build_angular/src/protractor/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,11 @@ export class ProtractorBuilder implements Builder<ProtractorBuilderOptions> {
private _startDevServer(options: ProtractorBuilderOptions) {
const architect = this.context.architect;
const [project, targetName, configuration] = (options.devServerTarget as string).split(':');
// Override browser build watch setting.
const overrides = { watch: false, host: options.host, port: options.port };
// Override dev server watch setting.
const overrides: Partial<DevServerBuilderOptions> = { watch: false };
// Also override the port and host if they are defined in protractor options.
if (options.host !== undefined) { overrides.host = options.host; }
if (options.port !== undefined) { overrides.port = options.port; }
const targetSpec = { project, target: targetName, configuration, overrides };
const builderConfig = architect.getBuilderConfiguration<DevServerBuilderOptions>(targetSpec);
let devServerDescription: BuilderDescription;
Expand Down