Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular-devkit/build-angular): passing specs to protractor builder has no effect #12511

Merged
merged 1 commit into from
Oct 10, 2018
Merged

fix(@angular-devkit/build-angular): passing specs to protractor builder has no effect #12511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/angular_devkit/build_angular/src/protractor/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,10 @@ export class ProtractorBuilder implements Builder<ProtractorBuilderOptions> {
}

private _runProtractor(root: Path, options: ProtractorBuilderOptions): Observable<BuildEvent> {
const additionalProtractorConfig = {
const additionalProtractorConfig: Partial<ProtractorBuilderOptions> = {
elementExplorer: options.elementExplorer,
baseUrl: options.baseUrl,
spec: options.specs.length ? options.specs : undefined,
specs: options.specs.length ? options.specs : undefined,
suite: options.suite,
};

Expand Down
4 changes: 2 additions & 2 deletions packages/angular_devkit/build_angular/test/protractor/works_spec_large.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ describe('Protractor Builder', () => {

it('overrides protractor specs', (done) => {
host.scopedSync().rename(normalize('./e2e/app.e2e-spec.ts'),
normalize('./e2e/renamed-app.e2e-spec.ts'));
normalize('./e2e/renamed-app.e2e.spec.ts'));

const overrides = { specs: ['./e2e/renamed-app.e2e-spec.ts'] };
const overrides = { specs: ['./e2e/renamed-app.e2e.spec.ts'] };

runTargetSpec(host, protractorTargetSpec, overrides).pipe(
retry(3),
Expand Down