Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@ngtools/webpack): avoid checking watchMode in environment hook #13133

Merged
merged 1 commit into from Dec 6, 2018
Merged

fix(@ngtools/webpack): avoid checking watchMode in environment hook #13133

merged 1 commit into from Dec 6, 2018

Conversation

clydin
Copy link
Member

@clydin clydin commented Dec 5, 2018 •
edited

The environment/afterEnvironment hooks occur before watchMode is valid.

Closes #13102

@clydin clydin added the target: patch This PR is targeted for the next patch release label Dec 5, 2018
@alexeagle alexeagle merged commit ea65cc2 into angular:master Dec 6, 2018
@clydin clydin deleted the fix-rebuild-times branch December 6, 2018 20:09
@alan-agius4 alan-agius4 mentioned this pull request Dec 7, 2018
Closed
@filipesilva filipesilva mentioned this pull request Dec 12, 2018
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slower compilation when using @ngtools/webpack@7.1.0
4 participants
@clydin @alan-agius4 @alexeagle @googlebot