New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@ngtools/webpack): avoid checking watchMode in environment hook #13133

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
4 participants
@clydin
Member

clydin commented Dec 5, 2018

The environment/afterEnvironment hooks occur before watchMode is valid.

Closes #13102

@alexeagle alexeagle merged commit ea65cc2 into angular:master Dec 6, 2018

13 checks passed

ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-node-8 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@clydin clydin deleted the clydin:fix-rebuild-times branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment