Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add renovate configuration #13178

Merged
merged 1 commit into from Dec 17, 2018
Merged

ci: add renovate configuration #13178

merged 1 commit into from Dec 17, 2018

Conversation

alan-agius4
Copy link
Collaborator

Since we have a lot of pin dependencies renovate will help us automate dependency updates.

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Dec 12, 2018
@clydin
Copy link
Member

clydin commented Dec 12, 2018

We should probably exclude all package.json templates inside schematic packages

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Dec 12, 2018

Actually, I don't think it's needed, as the templates are not valid package.json files. Ie, npm outdated cannot be executed against these files.

Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some scheduling for it? otherwise it will send us a large volume of little PRs for each dep that publishes an update, which takes our time and CI resources

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Dec 14, 2018

@alexeagle I add a rate limiting of 2 PR / hour. and scheduled it run between 10pm - 4am every weekday (Pacific Time US) and run freely during the weekends.

Since we have a lot of pin dependencies renovate will help us automate dependency updates.

`source-map` is listed as ignored as at the moment we cannot update this since their API changed to async and and this repos Code Coverage is sync.

`webpack-subresource-integrity` - the newer version requires peerDependencies that we don't want to include.
@alexeagle
Copy link
Contributor

I don't think this scheduling actually improves it, we can still get 12 PR's per day. I'd rather get one PR a week or so. But let's try this and see how it works.

@alexeagle alexeagle merged commit 37f4d1d into angular:master Dec 17, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants