chore(docs): add webpack update instructions #1456

filipesilva · 2016-07-26T23:25:39Z

Blocked by #1455 and angular-cli@webpack release. This PR should not be merged before we do a release, as there are more changes that can happen meanwhile.

Things that need to be incorporated into the guide:

mention that existing sass/etc files need to be renamed in styleUrls to include their real suffix, in beta.10 we were always using .css suffix in the array.
mobile app upgrade instructions

hansl · 2016-07-27T04:49:19Z

LGTM.

martinleopold · 2016-07-27T08:01:59Z

WEBPACK_UPDATE.md

+  * `./config/karma-test-shim.js`
+  * `./src/app/system-config.ts`
+  * `./angular-cli-build.js`
+  * `./typings.json`


Line 37 says ./typings.json is updated, here (Line 50) it can be deleted. Typo?

Typo indeed, fixed now!

intellix · 2016-07-27T12:50:39Z

Also another note. Even if I do this for a new project, ng serve gives me:

No angular-cli-build.js found. Please see the transition guide: https://github.com/angular-cli/angular-cli/blob/master/TRANSITION.md#user-content-brocfile-transition.

I believe this is because addon/ng2/blueprints/ng2/files/package.json ends up referencing angular-cli@1.0.0-beta.10. (I did the install using an npm linked angular-cli on webpack branch as well)

filipesilva · 2016-07-27T13:34:45Z

@intellix at the moment we haven't yet done the webpack release mentioned in the instructions so you're basically just running with master, so the following instructions apply:

https://github.com/angular/angular-cli#development-hints-for-hacking-on-angular-cli

There's a shortcut you can use as well, ng new --link-cli, which will do the linking for you.

filipesilva · 2016-07-27T16:02:49Z

(closed by accident)

Brocco · 2016-07-28T00:54:01Z

WEBPACK_UPDATE.md

+## Local project package:
+```
+rm -rf node_modules dist tmp typings
+npm install --save-dev angular-cli@webpack


With the release to npm w/ webpack the @webpack is not needed

Hans said that the release would not be made as 1.0.0-beta.11 but rather as webpack, so we need to install that particular version for now.

elvirdolic · 2016-07-29T07:36:02Z

If you use sass. You have also to rename your css files to .scss or .sass in templateUrl otherwise It won't be picked up and an error message is shown.

filipesilva · 2016-07-29T14:29:19Z

@elvirdolic good point. I'll add that to a list on the first comment so that it's updated before the release.

delasteve · 2016-08-02T12:56:11Z

WEBPACK_UPDATE.md

+1. Updated files:
+  * `./config/karma.conf.js` - `frameworks`/`plugins`/`files`/`exclude`/`preprocessors` entries changed, added `angularCliConfig` entry.
+  * `./e2e/tsconfig.json` - property cleanup, changed `outdir`, added `typeRoots`
+  * `./package.json` - removed typings postinstall script, removed `ember-cli-inject-live-reload`/`es6-shim`/`systemjs` dependencies, added `core-js`/`ts-helpers` dependencies, updated `angular-cli`/`codelyzer`/`ts-node`/`ts-lint`/`typescript` devDependencies, added `@types/jasmine`/`@types/protractor`/`karma-coverage` devDependencies.


Should #1468 be merged in before the @webpack release, karma-remap-istanbul will be added to the devDependencies list.

Aiming to get his merged in asap, so will update it later with this change for an upcoming release.

hansl · 2016-08-03T15:33:25Z

WEBPACK_UPDATE.md

@@ -0,0 +1,59 @@
+# Upgrading from angular-cli@1.0.0-beta.10 to the angular-cli@1.0.0-beta.11-webpack 
+
+To update `angular-cli` to the webpack preview, you must update both the global package, project's local package and your project files.


Technically the global package shouldn't care about it. Only the local package needs to be installed.

This is the official update procedure for ember-cli itself actually. I don't think it's a good idea to have de-synced versions of global and local... plus without the global version your ng new will generate old projects.

hansl · 2016-08-03T16:12:15Z

WEBPACK_UPDATE.md

+
+## Project files
+
+You will need to run `ng init` to check for changes in all the auto-generated files created by `ng new` and allow you to update yours. You are offered four choices for each changed file: `y` (overwrite), `n` (don't overwrite), `d` (show diff between your file and the updated file) and `h` (help).


Please remove ng init. It's dangerous that people are relying on it; it will not touch files that have been deleted, or files added by the user. We need to list a higher level list of things to take care when updating the application.

hansl · 2016-08-03T16:57:50Z

I still have pretty strong comments about the structure of this document, but if you insist on getting this in first and then working on incremental updates I'm fine with its state right now.

wouterkirstein · 2016-11-23T08:15:25Z

Hi there, I am trying a lot of approaches to migrate from my current project running on systemJS based on the quick-start to the format of the angular-cli. Do you maybe have some advice?

filipesilva · 2016-12-22T18:55:56Z

@wouterkirstein I'd say this:

make a new project using ng new
copy over the whole app into ./src/
configure your main.ts in angular-cli.json (and anything else you see is different)
remove any module.id you have in components (not needed)
make all html/css paths in components relative

If you still have problems then stack overflow is the best place to ask.

wouterkirstein · 2016-12-23T07:43:59Z

Hi Filipe! Thanks for all the help appreciated! Wouter From: Filipe Silva <notifications@github.com> To: angular/angular-cli <angular-cli@noreply.github.com> Cc: Wouter Kirstein <wouterk2001@yahoo.com>; Mention <mention@noreply.github.com> Sent: Thursday, December 22, 2016 8:56 PM Subject: Re: [angular/angular-cli] chore(docs): add webpack update instructions (#1456) @wouterkirstein I'd say this: - make a new project using ng new - copy over the whole app into ./src/ - configure your main.ts in angular-cli.json (and anything else you see is different) - remove any module.id you have in components (not needed) - make all html/css paths in components relative If you still have problems then stack overflow is the best place to ask.— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

angular-automatic-lock-bot · 2019-09-11T18:41:00Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jul 26, 2016

filipesilva force-pushed the webpack-update-instructions branch 2 times, most recently from c7e8ffd to 519d8e3 Compare July 26, 2016 23:29

TheLarkInn added the pr_state: LGTM label Jul 27, 2016

martinleopold reviewed Jul 27, 2016
View reviewed changes

filipesilva force-pushed the webpack-update-instructions branch from 2db4568 to 43b3276 Compare July 27, 2016 13:33

filipesilva closed this Jul 27, 2016

filipesilva deleted the webpack-update-instructions branch July 27, 2016 13:48

hansl mentioned this pull request Jul 27, 2016

Merge Webpack Feature branch into Master #1455

Merged

filipesilva restored the webpack-update-instructions branch July 27, 2016 16:02

filipesilva reopened this Jul 27, 2016

martinleopold mentioned this pull request Jul 27, 2016

Update to new angular-cli@webpack StudioProcess/rvp#90

Closed

Brocco reviewed Jul 28, 2016
View reviewed changes

filipesilva force-pushed the webpack-update-instructions branch from 95dd6b5 to 061fc54 Compare July 28, 2016 01:35

filipesilva added state: WIP and removed pr_state: LGTM labels Jul 29, 2016

filipesilva mentioned this pull request Jul 29, 2016

ng build -prod fails to clean up files #1068

Closed

delasteve reviewed Aug 2, 2016
View reviewed changes

filipesilva force-pushed the webpack-update-instructions branch 2 times, most recently from 17de707 to 79f1a00 Compare August 3, 2016 15:07

filipesilva added pr_action: review and removed state: WIP labels Aug 3, 2016

hansl reviewed Aug 3, 2016
View reviewed changes

filipesilva force-pushed the webpack-update-instructions branch from 79f1a00 to cdaa8de Compare August 3, 2016 16:03

chore(docs): add webpack update instructions

cdaa8de

hansl reviewed Aug 3, 2016
View reviewed changes

hansl added pr_state: LGTM and removed pr_action: review labels Aug 3, 2016

filipesilva merged commit 5ea4b03 into angular:master Aug 3, 2016

filipesilva deleted the webpack-update-instructions branch August 3, 2016 17:33

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(docs): add webpack update instructions #1456

chore(docs): add webpack update instructions #1456

filipesilva commented Jul 26, 2016 •

edited

hansl commented Jul 27, 2016

martinleopold Jul 27, 2016

filipesilva Jul 27, 2016

intellix commented Jul 27, 2016 •

edited

filipesilva commented Jul 27, 2016

filipesilva commented Jul 27, 2016

Brocco Jul 28, 2016

filipesilva Jul 28, 2016

elvirdolic commented Jul 29, 2016

filipesilva commented Jul 29, 2016

delasteve Aug 2, 2016

filipesilva Aug 3, 2016

hansl Aug 3, 2016

filipesilva Aug 3, 2016

hansl Aug 3, 2016

hansl commented Aug 3, 2016

wouterkirstein commented Nov 23, 2016

filipesilva commented Dec 22, 2016

wouterkirstein commented Dec 23, 2016 via email

angular-automatic-lock-bot bot commented Sep 11, 2019

		@@ -0,0 +1,59 @@
		# Upgrading from angular-cli@1.0.0-beta.10 to the angular-cli@1.0.0-beta.11-webpack

		To update `angular-cli` to the webpack preview, you must update both the global package, project's local package and your project files.


		## Project files

		You will need to run `ng init` to check for changes in all the auto-generated files created by `ng new` and allow you to update yours. You are offered four choices for each changed file: `y` (overwrite), `n` (don't overwrite), `d` (show diff between your file and the updated file) and `h` (help).

chore(docs): add webpack update instructions #1456

chore(docs): add webpack update instructions #1456

Conversation

filipesilva commented Jul 26, 2016 • edited

hansl commented Jul 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

intellix commented Jul 27, 2016 • edited

filipesilva commented Jul 27, 2016

filipesilva commented Jul 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elvirdolic commented Jul 29, 2016

filipesilva commented Jul 29, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hansl commented Aug 3, 2016

wouterkirstein commented Nov 23, 2016

filipesilva commented Dec 22, 2016

wouterkirstein commented Dec 23, 2016 via email

angular-automatic-lock-bot bot commented Sep 11, 2019

filipesilva commented Jul 26, 2016 •

edited

intellix commented Jul 27, 2016 •

edited