Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@ngtools/webpack): add support for raw-loader 2 and 3 #15311

Merged
merged 1 commit into from Aug 12, 2019
Merged

feat(@ngtools/webpack): add support for raw-loader 2 and 3 #15311

merged 1 commit into from Aug 12, 2019

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Aug 12, 2019

With this change we add support for raw-loader 1, 2 and 3.

In version 2 raw-loader released a breaking change https://github.com/webpack-contrib/raw-loader/releases/tag/v2.0.0 and now they use ES Module export instead of CommonJS.

Closes #15286 and closes #15149

@alan-agius4 alan-agius4 changed the title wip! raw-loader feat(@ngtools/webpack): add support for raw-loader 2 and 3 Aug 12, 2019
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed state: WIP labels Aug 12, 2019
@alan-agius4 alan-agius4 marked this pull request as ready for review August 12, 2019 12:02
With this change we add support for raw-loader 1, 2 and 3.

In version 2 raw-loader released a breaking change https://github.com/webpack-contrib/raw-loader/releases/tag/v2.0.0 and now they use ES Module export instead of CommonJS.

Closes #15286 and closes #15149
@mgechev mgechev merged commit 99ba5eb into angular:master Aug 12, 2019
alan-agius4 added a commit that referenced this pull request Aug 12, 2019
@alan-agius4 alan-agius4 deleted the raw-loader branch August 12, 2019 17:48
@falsyvalues
Copy link

🎉

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
4 participants