fix(@angular/cli): improve statues and description logs during update #15951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
alan-agius4
changed the title
|
Also needs angular/angular#33440 |
clydin
reviewed
Oct 28, 2019
With this change we improve the log messages of migration; > the migration description > the outcome of the migration > we also remove the version of the migration which was misleading (Ex: 9.0.0-beta)
…s a workflow error
clydin
reviewed
Oct 28, 2019
clydin
approved these changes
Oct 28, 2019
AndrewKushnir
pushed a commit
to angular/angular
that referenced
this pull request
Oct 29, 2019
With the next version of the CLI we don't need to add logging for the description of the schematic as part of the schematic itself. This is because now, the CLI will print the description defined in the `migrations.json` file. See: angular/angular-cli#15951 PR Close #33440
|
Need FW release |
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
With the next version of the CLI we don't need to add logging for the description of the schematic as part of the schematic itself. This is because now, the CLI will print the description defined in the `migrations.json` file. See: angular/angular-cli#15951 PR Close angular#33440
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
With the next version of the CLI we don't need to add logging for the description of the schematic as part of the schematic itself. This is because now, the CLI will print the description defined in the `migrations.json` file. See: angular/angular-cli#15951 PR Close angular#33440
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we improve the log messages of migration;
Example of new logs
