Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix production build - issue #1644 #1662

Closed
wants to merge 2 commits into from

Conversation

abner
Copy link
Contributor

@abner abner commented Aug 12, 2016

changed mangle configuration to mangle: { screw_ie8 : true, keep_fnames: true } to fix production builds issue - see #1644

…es: true } to fix production builds issue - see angular#1644

This fixes issue [angular#1644
@abner
Copy link
Contributor Author

abner commented Aug 12, 2016

as we can see in this pull request, this is even the way on angular own build. https://github.com/angular/angular/pull/7988/files

@TheLarkInn
Copy link
Member

@hansl This is technically the change we were talking about yesterday.

@abner will you sync your branch with master.

@hansl
Copy link
Contributor

hansl commented Aug 12, 2016

Yes this is what's needed to fix the issue. We can revert it once we support offline compiler

@abner
Copy link
Contributor Author

abner commented Aug 12, 2016

ok @TheLarkInn. just did it.

@TheLarkInn
Copy link
Member

@abner still looks like this branch is out of date with latest master.

@filipesilva
Copy link
Contributor

@TheLarkInn @abner I'm updating it myself, no worries.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants