Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/pwa): add purpose any to manifest icons #17386

Merged
merged 1 commit into from
Apr 6, 2020
Merged

fix(@angular/pwa): add purpose any to manifest icons #17386

merged 1 commit into from
Apr 6, 2020

Conversation

alan-agius4
Copy link
Collaborator

The purpose property defines the purpose of an icon, for example if the icon is intended to serve some special purpose in the context of the host OS (i.e., for better integration).

Purpose can have one or more of the following values, separated by spaces:

  • badge: A user agent can present this icon where space constraints and/or color requirements differ from those of the application icon.
  • maskable: The image is designed with icon masks and safe zone in mind, such that any part of the image outside the safe zone can safely be ignored and masked away by the user agent.
  • any: The user agent is free to display the icon in any context (this is the default value).

Closes #17384

The `purpose` property defines the purpose of an icon, for example if the icon is intended to serve some special purpose in the context of the host OS (i.e., for better integration).

`Purpose` can have one or more of the following values, separated by spaces:

- `badge`: A user agent can present this icon where space constraints and/or color requirements differ from those of the application icon.
- `maskable`: The image is designed with icon masks and safe zone in mind, such that any part of the image outside the safe zone can safely be ignored and masked away by the user agent.
- `any`: The user agent is free to display the icon in any context (this is the default value).

Closes #17384
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Apr 3, 2020
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 3, 2020
@mgechev mgechev merged commit 1ba4d73 into angular:master Apr 6, 2020
@alan-agius4 alan-agius4 deleted the pwa-icon-purpose branch April 6, 2020 17:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWA No supplied icon is at least 144px square
4 participants