Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example on README #17534

Closed
wants to merge 1 commit into from
Closed

Fix example on README #17534

wants to merge 1 commit into from

Conversation

shmool
Copy link

@shmool shmool commented Apr 23, 2020

The method workspaces.readWorkspace() returns an object containing the member workspace, and not the workspace itself directly.

Added destructuring to the assignment of workspace.

The method `workspaces.readWorkspace()` returns an object containing the member `workspace`, and not the workspace itself directly.
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Can you please fix the commit message to

docs: update `readWorkspace` usage in readme

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 23, 2020
@alan-agius4
Copy link
Collaborator

Addressed in #18440

@alan-agius4 alan-agius4 closed this Aug 6, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants