Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update release docs to use annotated tags for releases #18322

Merged
merged 1 commit into from Jul 23, 2020
Merged

ci: update release docs to use annotated tags for releases #18322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/process/release.md
View file
Open in desktop
Expand Up @@ -121,7 +121,7 @@ As commits are cherry-picked when PRs are merged, creating the release should be

```bash
git commit -a -m 'release: vXX'
git tag 'vXX'
git tag -a 'vXX' -m 'release: tag vXX'
```

The package versions we are about to publish are derived from the git tag that
Expand All @@ -132,11 +132,11 @@ following command.
yarn admin packages --version
```

Now push the commit and the tag to the upstream repository.
**Make sure to run these commands together, as missing tags can cause CI failures.**
Now push the commit and the tag to the upstream repository. **Make sure to use
`--follow-tags, as tags need to be pushed immediately or CI may fail!**

```bash
git push upstream && git push upstream --tags
git push upstream --follow-tags
```

### Authenticating
Expand Down