Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@schematics/angular): show info message when depending on rxjs-compat #18349

Merged
merged 1 commit into from Jul 27, 2020
Merged

fix(@schematics/angular): show info message when depending on rxjs-compat #18349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/schematics/angular/migrations/update-10/update-dependencies.ts
View file
Open in desktop
Expand Up @@ -51,14 +51,22 @@ export default function (): Rule {

// Check for @angular-devkit/schematics and @angular-devkit/core
for (const name of ['@angular-devkit/schematics', '@angular-devkit/core']) {
const current = getPackageJsonDependency(host, name);
if (current) {
if (getPackageJsonDependency(host, name)) {
context.logger.info(
`Package "${name}" found in the workspace package.json. ` +
'This package typically does not need to be installed manually. ' +
'If it is not being used by project code, it can be removed from the package.json.',
);
}
}

if (getPackageJsonDependency(host, 'rxjs-compat')) {
context.logger.info(
`Package "rxjs-compat" found in the workspace package.json. ` +
'This package typically was used during migration from RxJs version 5 to 6 during the Angular 5 ' +
'timeframe and may no longer be needed.\n' +
'Read more about this: https://rxjs-dev.firebaseapp.com/guide/v6/migration',
);
}
};
}