Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master CI fixes #18360

Merged
merged 4 commits into from Jul 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .circleci/config.yml
Expand Up @@ -42,6 +42,7 @@ executors:
default: *default_nodeversion
docker:
- image: cimg/node:<< parameters.nodeversion >>
working_directory: ~/ng
resource_class: small

test-executor:
Expand All @@ -51,12 +52,14 @@ executors:
default: *default_nodeversion
docker:
- image: cimg/node:<< parameters.nodeversion >>
working_directory: ~/ng
environment:
NPM_CONFIG_PREFIX: ~/.npm-global
resource_class: large

windows-executor:
# Same as https://circleci.com/orbs/registry/orb/circleci/windows, but named.
working_directory: ~/ng
resource_class: windows.medium
shell: powershell.exe -ExecutionPolicy Bypass
machine:
Expand Down Expand Up @@ -121,7 +124,6 @@ jobs:
setup:
executor: action-executor
resource_class: medium
working_directory: /mnt/ramdisk
steps:
- checkout
- run:
Expand Down
4 changes: 2 additions & 2 deletions integration/angular_cli/package.json
Expand Up @@ -8,7 +8,7 @@
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e --prod",
"postinstall": "webdriver-manager update --standalone false --gecko false --versions.chrome 84.0.4147.30"
"postinstall": "webdriver-manager update --standalone false --gecko false --versions.chrome 85.0.4183.38"
},
"private": true,
"dependencies": {
Expand Down Expand Up @@ -40,7 +40,7 @@
"karma-jasmine": "~3.3.0",
"karma-jasmine-html-reporter": "^1.5.0",
"protractor": "~5.4.3",
"puppeteer": "3.0.2",
"puppeteer": "5.2.1",
"ts-node": "~8.3.0",
"tslint": "~6.1.0",
"typescript": "~3.9.2"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -37,7 +37,7 @@
"preinstall": "node ./tools/yarn/check-yarn.js",
"postinstall": "yarn webdriver-update && yarn ngcc",
"//webdriver-update-README": "ChromeDriver version must match Puppeteer Chromium version, see https://github.com/GoogleChrome/puppeteer/releases http://chromedriver.chromium.org/downloads",
"webdriver-update": "webdriver-manager update --standalone false --gecko false --versions.chrome 84.0.4147.30",
"webdriver-update": "webdriver-manager update --standalone false --gecko false --versions.chrome 85.0.4183.38",
"ngcc": "ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points"
},
"repository": {
Expand Down
Expand Up @@ -8,10 +8,10 @@ const collectionPath = path.join(__dirname, '../collection.json');


describe('my-full-schematic', () => {
it('requires required option', () => {
it('requires required option', async () => {
// We test that
const runner = new SchematicTestRunner('schematics', collectionPath);
expectAsync(runner.runSchematicAsync('my-full-schematic', {}, Tree.empty()).toPromise()).toBeRejected();
await expectAsync(runner.runSchematicAsync('my-full-schematic', {}, Tree.empty()).toPromise()).toBeRejected();
});

it('works', async () => {
Expand Down
1 change: 1 addition & 0 deletions tests/legacy-cli/e2e/tests/schematics_cli/blank-test.ts
Expand Up @@ -17,6 +17,7 @@ export default async function () {
'install',
'-g',
'@angular-devkit/schematics-cli',
'--registry=http://localhost:4873',
);
await exec(process.platform.startsWith('win') ? 'where' : 'which', 'schematics');

Expand Down
Expand Up @@ -17,6 +17,7 @@ export default async function () {
'install',
'-g',
'@angular-devkit/schematics-cli',
'--registry=http://localhost:4873',
);
await exec(process.platform.startsWith('win') ? 'where' : 'which', 'schematics');

Expand Down