Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schematics code cleanup and refactoring to support strict compilation #18415

Merged
merged 4 commits into from
Aug 3, 2020
Merged

Schematics code cleanup and refactoring to support strict compilation #18415

merged 4 commits into from
Aug 3, 2020

Commits on Jul 31, 2020

  1. fix(@schematics/angular): warn when migrating to v6 if asset glob is … 

    …missing
    @clydin
    clydin committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    86b817d View commit details
    Browse the repository at this point in the history

  2. refactor(@schematics/angular): use type guard based narrowing with TS… 

    … AST

By leveraging TypeScript's AST type guards, function parameter assumptions and casting can be removed.  Many of these cases caused errors when enabling TypeScript's strict option. This is preliminary work to support enabling full TypeScript strict mode within the project.
    @clydin
    clydin committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    b1ae259 View commit details
    Browse the repository at this point in the history

  3. refactor(@schematics/update): adjust types to support strict mode

    @clydin
    clydin committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    3506712 View commit details
    Browse the repository at this point in the history

  4. refactor(@schematics/angular): avoid InsertChange type assumptions 

    This change introduces a helper function (`applyToUpdateRecorder`) that handles all known `Change` classes.  The use of this helper function removes type assumptions within the schematics.  Many of these assumptions caused compilation errors when strict TypeScript options are enabled.
    @clydin
    clydin committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    38fa1fc View commit details
    Browse the repository at this point in the history