Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and styling nits #18440

Merged
merged 4 commits into from Aug 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .editorconfig
Expand Up @@ -9,6 +9,7 @@ indent_size = 2
insert_final_newline = true
spaces_around_brackets = inside
trim_trailing_whitespace = true
quote_type = single

[*.md]
insert_final_newline = false
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Expand Up @@ -26,8 +26,8 @@ should be tagged with tag `angular-cli` or `angular-devkit`.

StackOverflow is a much better place to ask questions since:

- there are thousands of people willing to help on StackOverflow
- questions and answers stay available for public viewing so your question / answer might help someone else
- There are thousands of people willing to help on StackOverflow.
- Questions and answers stay available for public viewing so your question / answer might help someone else.
- StackOverflow's voting system assures that the best answers are prominently visible.

To save your and our time we will be systematically closing all the issues that are requests for
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/core/README.md
Expand Up @@ -144,7 +144,7 @@ import { workspaces } from '@angular-devkit/core';

async function demonstrate() {
const host = workspaces.createWorkspaceHost(new NodeJsSyncHost());
const workspace = await workspaces.readWorkspace('path/to/workspace/directory/', host);
const { workspace } = await workspaces.readWorkspace('path/to/workspace/directory/', host);

const project = workspace.projects.get('my-app');
if (!project) {
Expand Down
4 changes: 2 additions & 2 deletions scripts/templates/contributing.ejs
Expand Up @@ -26,8 +26,8 @@ should be tagged with tag `angular-cli` or `angular-devkit`.

StackOverflow is a much better place to ask questions since:

- there are thousands of people willing to help on StackOverflow
- questions and answers stay available for public viewing so your question / answer might help someone else
- There are thousands of people willing to help on StackOverflow.
- Questions and answers stay available for public viewing so your question / answer might help someone else.
- StackOverflow's voting system assures that the best answers are prominently visible.

To save your and our time we will be systematically closing all the issues that are requests for
Expand Down
4 changes: 2 additions & 2 deletions scripts/validate-licenses.ts
Expand Up @@ -25,7 +25,7 @@ const spdxSatisfies = require('spdx-satisfies');
* - Public Domain
* Same as CC0, it is not a valid license.
*/
const licensesWhitelist = [
const allowedLicenses = [
// Regular valid open source licenses supported by Google.
'MIT',
'ISC',
Expand Down Expand Up @@ -114,7 +114,7 @@ export default function (_options: {}, logger: logging.Logger): Promise<number>
.map(x => x.replace(/\*$/, ''))
.map(x => x in licenseReplacements ? licenseReplacements[x] : x),
}))
.filter(pkg => !_passesSpdx(pkg.licenses, licensesWhitelist))
.filter(pkg => !_passesSpdx(pkg.licenses, allowedLicenses))
.filter(pkg => !ignoredPackages.find(ignored => ignored === pkg.id));

// Report packages with bad licenses
Expand Down