Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow private packages as commit scopes #18991

Merged
merged 3 commits into from Oct 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ng-dev/commit-message.ts
Expand Up @@ -17,6 +17,6 @@ export const commitMessage: CommitMessageConfig = {
minBodyLength: 0,
minBodyLengthTypeExcludes: ['docs'],
scopes: [
...Object.keys(packages).filter(name => !packages[name].private),
...Object.keys(packages),
],
};
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Expand Up @@ -215,6 +215,7 @@ The following is the list of supported scopes:
* **@angular/pwa**
* **@angular-devkit/architect**
* **@angular-devkit/architect-cli**
* **@angular-devkit/benchmark**
* **@angular-devkit/build-angular**
* **@angular-devkit/build-ng-packagr**
* **@angular-devkit/build-optimizer**
Expand Down
3 changes: 1 addition & 2 deletions packages/README.md
Expand Up @@ -2,8 +2,7 @@

This folder is the root of all defined packages in this repository.

Packages that are marked as `private: true` will not be published to NPM. These are limited to the
`_` subfolder.
Packages that are marked as `private: true` will not be published to NPM.

This folder includes a directory for every scope in NPM, without the `@` sign. Then one folder
per package, which contains the `package.json`.
11 changes: 0 additions & 11 deletions packages/_/benchmark/package.json

This file was deleted.

86 changes: 0 additions & 86 deletions packages/_/benchmark/src/benchmark.ts

This file was deleted.

8 changes: 0 additions & 8 deletions packages/_/benchmark/src/index.ts

This file was deleted.

9 changes: 0 additions & 9 deletions packages/_/devkit/collection.json

This file was deleted.

14 changes: 0 additions & 14 deletions packages/_/devkit/package.json

This file was deleted.

102 changes: 0 additions & 102 deletions packages/_/devkit/package/factory.ts

This file was deleted.

3 changes: 0 additions & 3 deletions packages/_/devkit/package/project-files/__path__/README.md

This file was deleted.

16 changes: 0 additions & 16 deletions packages/_/devkit/package/project-files/__path__/package.json

This file was deleted.

10 changes: 0 additions & 10 deletions packages/_/devkit/package/project-files/__path__/src/index.ts

This file was deleted.

32 changes: 0 additions & 32 deletions packages/_/devkit/package/schema.json

This file was deleted.

25 changes: 0 additions & 25 deletions packages/angular_devkit/core/src/json/parser_benchmark.ts

This file was deleted.