Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(@angular/cli): pin @angular/material package to version 10 #19478

Merged
merged 2 commits into from Nov 25, 2020
Merged

test(@angular/cli): pin @angular/material package to version 10 #19478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82c392c
test(@angular/cli): fix ng add @angular/material package test
alan-agius4 Nov 24, 2020
78f4f48
test(@angular/cli): pin down @angular/core versions to 10.x.x
alan-agius4 Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions tests/legacy-cli/e2e/tests/commands/add/add-material.ts
View file
Open in desktop
Expand Up @@ -25,11 +25,6 @@ export default async function () {
throw new Error('Installation was not skipped');
}

const output2 = await ng('add', '@angular/material@latest');
if (output2.stdout.includes('Skipping installation: Package already installed')) {
throw new Error('Installation should not have been skipped');
}

const output3 = await ng('add', '@angular/material@8.0.0');
if (output3.stdout.includes('Skipping installation: Package already installed')) {
throw new Error('Installation should not have been skipped');
Expand Down
2 changes: 1 addition & 1 deletion tests/legacy-cli/e2e/tests/update/update-1.0.ts
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ export default async function() {
await ng('update', '@angular/cli');
await useBuiltPackages();
await silentNpm('install');
await ng('update', '@angular/core', ...extraUpdateArgs);
await ng('update', '@angular/core@10', ...extraUpdateArgs);
await useCIDefaults('one-oh-project');
await ng('generate', 'component', 'my-comp');
await ng('test', '--watch=false');
Expand Down
2 changes: 1 addition & 1 deletion tests/legacy-cli/e2e/tests/update/update-1.7-longhand.ts
View file
Open in desktop
Expand Up @@ -12,6 +12,6 @@ export default async function() {
await ng('update', '@angular/cli', '--migrate-only', '--from=1.7.1');
await useBuiltPackages();
await silentNpm('install');
await ng('update', '@angular/core', ...extraUpdateArgs);
await ng('update', '@angular/core@10', ...extraUpdateArgs);
await ng('build');
}
2 changes: 1 addition & 1 deletion tests/legacy-cli/e2e/tests/update/update-1.7.ts
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ export default async function() {
await ng('update', '@angular/cli');
await useBuiltPackages();
await silentNpm('install');
await ng('update', '@angular/core', ...extraUpdateArgs);
await ng('update', '@angular/core@10', ...extraUpdateArgs);
await useCIDefaults('latest-project');
await ng('generate', 'component', 'my-comp');
await ng('test', '--watch=false');
Expand Down
2 changes: 1 addition & 1 deletion tests/legacy-cli/e2e/tests/update/update-7.0.ts
View file
Open in desktop
Expand Up @@ -31,7 +31,7 @@ export default async function() {

// Update Angular.
const extraUpdateArgs = (await isPrereleaseCli()) ? ['--next', '--force'] : [];
await ng('update', '@angular/core', ...extraUpdateArgs);
await ng('update', '@angular/core@10', ...extraUpdateArgs);

// Run CLI commands.
await ng('generate', 'component', 'my-comp');
Expand Down