Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove validate-do-not-submit check #19946

Merged
merged 1 commit into from Feb 3, 2021
Merged

ci: remove validate-do-not-submit check #19946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Expand Up @@ -174,9 +174,6 @@ jobs:
else
echo "This build is not over a PR, nothing to do."
fi
- run:
name: Validate "do not submit" Commits
command: yarn -s admin validate-do-not-submit
- run:
command: yarn -s admin validate --ci

Expand Down
79 changes: 0 additions & 79 deletions scripts/validate-do-not-submit.ts
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions scripts/validate.ts
View file
Open in desktop
Expand Up @@ -10,7 +10,6 @@ import { logging, tags } from '@angular-devkit/core';
import { execSync } from 'child_process';
import templates from './templates';
import validateBuildFiles from './validate-build-files';
import validateDoNotSubmit from './validate-do-not-submit';
import validateLicenses from './validate-licenses';
import validateUserAnalytics from './validate-user-analytics';

Expand Down Expand Up @@ -39,13 +38,6 @@ export default async function (options: { verbose: boolean; ci: boolean }, logge
error = true;
}

if (!options.ci) {
logger.info('');
logger.info(`Running DO_NOT${''}_SUBMIT validation...`);
error = await validateDoNotSubmit({}, logger.createChild('validate-do-not-submit')) != 0
|| error;
}

logger.info('');
logger.info('Running license validation...');
error = await validateLicenses({}, logger.createChild('validate-commits')) != 0
Expand Down