Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@schematics/angular): Do not include Protractor test in new project #20503

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Apr 12, 2021

Do not include Protractor for new projects since we do not have a concrete plan for Protractor yet.

Closes #18844

@google-cla google-cla bot added the cla: yes label Apr 12, 2021
@kyliau kyliau force-pushed the remove-protractor branch 6 times, most recently from 437a7b1 to 973c528 Compare April 13, 2021 00:44
@kyliau kyliau marked this pull request as ready for review April 20, 2021 17:14
@kyliau kyliau added the target: rc This PR is targeted for the next release-candidate label Apr 20, 2021
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional NIT, otherwise LGTM

…project

Do not include Protractor for new projects since we do not have a concrete
plan for Protractor yet.
Copy link

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Apr 20, 2021
@josephperrott josephperrott merged commit 49ba5e2 into angular:master Apr 21, 2021
@kyliau kyliau deleted the remove-protractor branch April 23, 2021 17:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker hotlist: release-blocker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing protractor as the default E2E tool
5 participants