Added support for running the webpack dev server in ssl mode

[sbaramov]

Added support for running the webpack dev server in ssl mode through 'ng serve' command. The command options --ssl, --ssl-key, and --ssl-cert are used to configure the server.

Fixes #1576.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[sbaramov]

i signed it

On Tue, Sep 13, 2016 at 4:12 PM googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your
  GitHub username or you're using a different email address. Check your
  existing CLA data https://cla.developers.google.com/clas and verify
  that your email is set on your git commits
  https://help.github.com/articles/setting-your-email-in-git/.
• If you signed the CLA as a corporation, please let us know the
  company's name.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2089 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ7-PfRzuYwimMKr9YG48-bNWn5_zy2uks5qpwOcgaJpZM4J8F5E
.

[googlebot]

CLAs look good, thanks!

[hansl]

Please also add an e2e test. You can store a dummy key in github.

[hansl]

This field should probably be optional.

[sbaramov]

@hansl , I am sorry but I do not see the e2e test for serve-webpack.ts. Can you give me some pointers?

[filipesilva]

@sbaramov the closest test I can find is the one for the proxy functionality, it also needs a file and does a request. See ./tests/e2e/tests/misc/proxy.ts

[zackarychapple]

This looks like a great feature, I would only request that you add another param for certificate authority. Both GoDaddy and Symantec have a ca that can go with the crt and key.

[sbaramov]

@filipesilva Thanks, the test is implemented now.

[Brocco]

Tests and all look good

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

[Brocco]

@sbaramov PR looks fine, just rebased it for merging & cla got out of whack, can you please comment again that you've signed it?

[sbaramov]

Yes i have signed the CLA.

[Brocco]

@sbaramov apparently losing the CLA signing is not something we can recover from on this PR, can you please submit the same code in a new PR?

Just tag me in it and I'll take a look. Take care to rebase prior to pushing the new one too, please.

[sbaramov]

Closing the pull request in favor of #2792 because the CLA did not work here.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}