Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): added webWorkerTsConfig into test options #21057

Merged
merged 2 commits into from Jun 7, 2021

Conversation

InSantoshMahto
Copy link
Contributor

I have found one issue while working with a web worker.
I have a simple web-worker and working perfectly with ng build but in the case of the ng test will fail.

after some time I found that "webWorkerTsConfig": "tsconfig.worker.json" missing in test options.

and also check --target with ng g web-worker CLI reference.

Today I have made a simple change in angular-cli so that it will also added same config into test if it available it will change.

@google-cla
Copy link

google-cla bot commented Jun 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 6, 2021
@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 6, 2021
@InSantoshMahto InSantoshMahto changed the title fix(@schematics/angular): added webWorkerTsConfig into test option fix(@schematics/angular): added webWorkerTsConfig into test options Jun 7, 2021
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 7, 2021
@alan-agius4 alan-agius4 merged commit d13a866 into angular:master Jun 7, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants