Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): explicitly set compilation target in test configuration #21118

Merged
merged 1 commit into from Jun 11, 2021
Merged

fix(@angular-devkit/build-angular): explicitly set compilation target in test configuration #21118

merged 1 commit into from Jun 11, 2021

Conversation

alan-agius4
Copy link
Collaborator

When not set, and browserslist returns no supported result due to the file being empty or commented. Webpack will generate invalid code because it doesn't know which enviorment we want to target.

- (self["webpackChunktest_app"] = self["webpackChunktest_app"] || []).push([["vendor"],{

/***/ 8583:

Closes #21111

… in test configuration

When not set, and browserslist returns no reesults due to the file being empty or commented. Webpack will generate invalid code because it doesn't know which enviorment we want to target.

```diff
- (self["webpackChunktest_app"] = self["webpackChunktest_app"] || []).push([["vendor"],{

/***/ 8583:
```

Closes #21111
@google-cla google-cla bot added the cla: yes label Jun 11, 2021
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed cla: yes labels Jun 11, 2021
@google-cla google-cla bot added the cla: yes label Jun 11, 2021
@alan-agius4 alan-agius4 requested a review from clydin June 11, 2021 13:10
@angular angular deleted a comment from google-cla bot Jun 11, 2021
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 11, 2021
@clydin clydin merged commit 8360251 into angular:master Jun 11, 2021
@alan-agius4 alan-agius4 deleted the webpack-target-test branch June 11, 2021 14:45
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng test exception via commented out .browserslistrc file
2 participants