Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@ngtools/webpack): improve symbols description #21139

Merged
merged 1 commit into from Jun 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ngtools/webpack/src/inline-data-loader.ts
Expand Up @@ -8,7 +8,7 @@

import type { Compilation, LoaderContext } from 'webpack';

export const InlineAngularResourceSymbol = Symbol();
export const InlineAngularResourceSymbol = Symbol('@ngtools/webpack[angular-resource]');

export interface CompilationWithInlineAngularResource extends Compilation {
[InlineAngularResourceSymbol]: string;
Expand Down
2 changes: 1 addition & 1 deletion packages/ngtools/webpack/src/ivy/plugin.ts
Expand Up @@ -127,7 +127,7 @@ export class AngularWebpackPlugin {

// Set resolver options
const pathsPlugin = new TypeScriptPathsPlugin();
compiler.hooks.afterResolvers.tap('angular-compiler', (compiler) => {
compiler.hooks.afterResolvers.tap(PLUGIN_NAME, (compiler) => {
// When Ivy is enabled we need to add the fields added by NGCC
// to take precedence over the provided mainFields.
// NGCC adds fields in package.json suffixed with '_ivy_ngcc'
Expand Down
2 changes: 1 addition & 1 deletion packages/ngtools/webpack/src/ivy/symbol.ts
Expand Up @@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/

export const AngularPluginSymbol = Symbol.for('@angular-devkit/build-angular[angular-compiler]');
export const AngularPluginSymbol = Symbol.for('@ngtools/webpack[angular-compiler]');

export interface EmitFileResult {
content?: string;
Expand Down