Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@ngtools/webpack): avoid non-actionable template type-checker syntax diagnostics #21313

Merged
merged 1 commit into from Jul 9, 2021
Merged

fix(@ngtools/webpack): avoid non-actionable template type-checker syntax diagnostics #21313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/ngtools/webpack/src/ivy/plugin.ts
View file
Open in desktop
Expand Up @@ -495,18 +495,18 @@ export class AngularWebpackPlugin {
}
}

// Collect non-semantic diagnostics
// Collect program level diagnostics
const diagnostics = [
...angularCompiler.getOptionDiagnostics(),
...builder.getOptionsDiagnostics(),
...builder.getGlobalDiagnostics(),
...builder.getSyntacticDiagnostics(),
];
diagnosticsReporter(diagnostics);

// Collect semantic diagnostics
// Collect source file specific diagnostics
for (const sourceFile of builder.getSourceFiles()) {
if (!ignoreForDiagnostics.has(sourceFile)) {
diagnosticsReporter(builder.getSyntacticDiagnostics(sourceFile));
diagnosticsReporter(builder.getSemanticDiagnostics(sourceFile));
}
}
Expand Down