Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(@ngtools/webpack): avoid exposing internal types in public API #21354

Merged
merged 1 commit into from
Jul 19, 2021
Merged

refactor(@ngtools/webpack): avoid exposing internal types in public API #21354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 5 additions & 8 deletions packages/ngtools/webpack/src/ivy/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,18 @@
*/

import * as path from 'path';
import type { LoaderContext } from 'webpack';
import { AngularPluginSymbol, FileEmitterCollection } from './symbol';

export function angularWebpackLoader(
this: import('webpack').LoaderContext<unknown> & {
[AngularPluginSymbol]?: FileEmitterCollection;
},
content: string,
map: string,
) {
export function angularWebpackLoader(this: LoaderContext<unknown>, content: string, map: string) {
const callback = this.async();
if (!callback) {
throw new Error('Invalid webpack version');
}

const fileEmitter = this[AngularPluginSymbol];
const fileEmitter = (
this as LoaderContext<unknown> & { [AngularPluginSymbol]?: FileEmitterCollection }
)[AngularPluginSymbol];
if (!fileEmitter || typeof fileEmitter !== 'object') {
if (this.resourcePath.endsWith('.js')) {
// Passthrough for JS files when no plugin is used
Expand Down