refactor(@schematics/angular): improve automatic versions #21401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: minor
josephperrott
approved these changes
Jul 22, 2021
| @@ -8,14 +8,14 @@ | |||
|
|
|||
| /** Retrieve the minor version for the provided version string. */ | |||
| function getEarliestMinorVersion(version: string) { | |||
| const versionMatching = version.match(/^(\d+)\.(\d+)\.*/); | |||
| const versionMatching = version.match(/^(\d+)\.(\d+)\.(?:\d+)(-\w+)?/); | |||
There was a problem hiding this comment.
Is it possible that @schematics/angular could move into rc while @angular/core is still in next resulting in a mismatch for this discovered prerelease segment?
There was a problem hiding this comment.
I don't think so, the FW is always released first.
clydin
reviewed
Jul 22, 2021
With this change we improve the versions we set in the users project to be less confusing. Previously, for both stable and next versions we set the versions of Angular packages to the below; ``` "@angular/animations": "~12.2.0-" ``` This might be problematic as one might not immediately notice that they might depend on a prerelease. The `-` is short character and can be missed when having a large set of dependencies. With this can we are more explicate by adding `--next` when it's a prerelease and omit the suffix for stable releases.
15 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we improve the versions we set in the users project to be less confusing. Previously, for both stable and next versions we set the versions of Angular packages to the below;
This might be problematic as one might not immediately notice that they might depend on a prerelease. The
-is short character and can be missed when having a large set of dependencies.With this can we are more explicate by adding
--nextwhen it's a prerelease and omit the suffix for stable releases.