-
Notifications
You must be signed in to change notification settings - Fork 11.9k
build: reproduce original package structure using bazel #22308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,12 +6,7 @@ | |
load("@npm//@bazel/jasmine:index.bzl", "jasmine_node_test") | ||
load("//tools:ts_json_schema.bzl", "ts_json_schema") | ||
load("//tools:ng_cli_schema_generator.bzl", "cli_json_schema") | ||
load("//tools:defaults.bzl", "ts_library") | ||
|
||
# @external_begin | ||
load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar") | ||
load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm") | ||
# @external_end | ||
load("//tools:defaults.bzl", "pkg_npm", "ts_library") | ||
gregmagolan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
licenses(["notice"]) # MIT | ||
|
||
|
@@ -61,7 +56,7 @@ ts_library( | |
exclude = [ | ||
# NB: we need to exclude the nested node_modules that is laid out by yarn workspaces | ||
"node_modules/**", | ||
"cli/lib/config/workspace-schema.json", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @alan-agius4 This path was wrong so There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that this file gets converted to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah it should be excluded. |
||
"lib/config/workspace-schema.json", | ||
], | ||
) + [ | ||
"//packages/angular/cli:lib/config/schema.json", | ||
|
@@ -312,19 +307,22 @@ jasmine_node_test( | |
srcs = [":angular-cli_test_lib"], | ||
) | ||
|
||
# @external_begin | ||
gregmagolan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
genrule( | ||
name = "license", | ||
srcs = ["//:LICENSE"], | ||
outs = ["LICENSE"], | ||
cmd = "cp $(execpath //:LICENSE) $@", | ||
) | ||
Comment on lines
+310
to
+315
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
pkg_npm( | ||
name = "npm_package", | ||
srcs = [":package.json"], | ||
deps = [ | ||
":README.md", | ||
":angular-cli", | ||
":license", | ||
":src/commands/update/schematic/collection.json", | ||
":src/commands/update/schematic/schema.json", | ||
":utilities/INITIAL_COMMIT_MESSAGE.txt", | ||
], | ||
) | ||
|
||
pkg_tar( | ||
name = "npm_package_archive", | ||
srcs = [":npm_package"], | ||
extension = "tar.gz", | ||
strip_prefix = "./npm_package", | ||
tags = ["manual"], | ||
) | ||
# @external_end |
Uh oh!
There was an error while loading. Please reload this page.