Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move tempdir creation to util method #23649

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

jbedard
Copy link
Contributor

@jbedard jbedard commented Jul 27, 2022

To put the login in a common location. This will allow easily using the bazel temp dir when converting to bazel.

@jbedard jbedard requested a review from alan-agius4 July 28, 2022 00:45
@jbedard jbedard marked this pull request as ready for review July 28, 2022 00:45
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 28, 2022
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one NIT

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 28, 2022
@jbedard jbedard requested a review from alan-agius4 July 28, 2022 16:09
@alan-agius4
Copy link
Collaborator

@jbedard, can you please squash?

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 28, 2022
@alan-agius4 alan-agius4 merged commit acd5ad5 into angular:main Jul 28, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants