test: remove ci specific logic #23686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
jbedard
commented
Aug 24, 2022
tests/legacy-cli/e2e/utils/assets.ts
Outdated
| @@ -51,10 +51,6 @@ export async function createProjectFromAsset( | |||
| process.chdir(dir); | |||
| if (!useNpmPackages) { | |||
| await useBuiltPackages(); | |||
| if (!getGlobalVariable('ci')) { | |||
There was a problem hiding this comment.
fwiw the registry is controlled using the environment variables. I think those variables even override this file so this was probably never doing anything?
|
Looks like other changes have made this PR essentially just removing an unused variable now 🤷 |
alan-agius4
approved these changes
Aug 31, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems unnecessary.
All the tests where the removed
ifis truthy seem to work locally and CI is green.