test: catch and log all errors include test setup #23903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
reviewed
Sep 14, 2022
tests/legacy-cli/e2e_runner.ts
Outdated
| if (shardId !== null) { | ||
| console.log(colors.green(`Done shard ${shardId} of ${nbShards}.`)); | ||
| } else { | ||
| console.log(colors.green('Done.')); | ||
| } | ||
| } catch (err) { | ||
|
|
||
| process.exit(0); |
There was a problem hiding this comment.
Why setting the exit code is needed? (If needed it would be better to use process.exitCode instead.)
alan-agius4
reviewed
Sep 14, 2022
tests/legacy-cli/e2e_runner.ts
Outdated
| @@ -175,13 +175,22 @@ Promise.all([findFreePort(), findFreePort()]) | |||
| await runSteps(runSetup, allSetups, 'setup'); | |||
| await runSteps(runInitializer, allInitializers, 'initializer'); | |||
| await runSteps(runTest, testsToRun, 'test'); | |||
|
|
|||
| } finally { | |||
| registryProcess.kill(); | |||
There was a problem hiding this comment.
This would cause the NPM registry to be terminated as well when debug is enabled.
jbedard
force-pushed
the
e2e-log-errors
branch
from
4b2635a
to
4e58e28
Compare
alan-agius4
approved these changes
Sep 19, 2022
alan-agius4
added
action: cleanup
jbedard
force-pushed
the
e2e-log-errors
branch
from
66f41c5
to
21f73e4
Compare
|
Squashed 👍 |
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a case of something else above throwing and it was hidden due to this.