Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular-devkit/core): update logger forEach promiseCtor type #24085

Merged
merged 1 commit into from Oct 14, 2022
Merged

fix(@angular-devkit/core): update logger forEach promiseCtor type #24085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion goldens/public-api/angular_devkit/core/index.md
View file
Open in desktop
Expand Up @@ -459,7 +459,7 @@ class Logger extends Observable<LogEntry> implements LoggerApi {
// (undocumented)
fatal(message: string, metadata?: JsonObject): void;
// (undocumented)
forEach(next: (value: LogEntry) => void, promiseCtor?: typeof Promise): Promise<void>;
forEach(next: (value: LogEntry) => void, promiseCtor?: PromiseConstructorLike): Promise<void>;
// (undocumented)
info(message: string, metadata?: JsonObject): void;
// (undocumented)
Expand Down
5 changes: 4 additions & 1 deletion packages/angular_devkit/core/src/logger/logger.ts
View file
Open in desktop
Expand Up @@ -162,7 +162,10 @@ export class Logger extends Observable<LogEntry> implements LoggerApi {
);
}

override forEach(next: (value: LogEntry) => void, promiseCtor?: typeof Promise): Promise<void> {
override forEach(
next: (value: LogEntry) => void,
promiseCtor?: PromiseConstructorLike,
): Promise<void> {
return this._observable.forEach(next, promiseCtor);
}
}