Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update @babel/generator to v7.20.3 #24193

Closed
wants to merge 1 commit into from

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 7, 2022

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The buildkit fails when input js contains // comment /* other comment */, this is a Babel bug fixed in @babel/generator v7.20.3.

Issue Number: babel/babel-loader#973

What is the new behavior?

It should work

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Also run yarn-deduplicate on the lock file.

@alan-agius4
Copy link
Collaborator

Hi @JLHwung, thanks for this but our dependency updates are managed by Renovate.

See: #24195

@alan-agius4 alan-agius4 closed this Nov 7, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants