Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(@ngtools/webpack): remove NGCC integration #24720

Merged
merged 1 commit into from
Feb 15, 2023
Merged

refactor(@ngtools/webpack): remove NGCC integration #24720

merged 1 commit into from
Feb 15, 2023

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Feb 15, 2023 •
edited

This commit removes usage of NGCC which was used to convert old View Engine libraries to Ivy.

BREAKING CHANGE: NGCC integration has been removed and as a result Angular View Engine libraries will no longer work.

@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Feb 15, 2023
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 15, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 15, 2023
@Lonli-Lokli Lonli-Lokli mentioned this pull request Feb 15, 2023
Closed
@alan-agius4
refactor(@ngtools/webpack): remove NGCC integration
158a561 
This commit removes usage of NGCC which was used to convert old View Engine libraries to Ivy.

BREAKING CHANGE: NGCC integration has been removed and as a result Angular View Engine libraries will no longer work.
@angular-robot angular-robot bot merged commit c8ac660 into angular:main Feb 15, 2023
@alan-agius4 alan-agius4 deleted the ngcc-removal branch February 15, 2023 22:21
atscott added a commit to atscott/vscode-ng-language-service that referenced this pull request Feb 15, 2023
@atscott
refactor: Remove ngcc from extension
fc03b58 
NGCC is being removed in Angular v16. The language service should not
longer attempt to run it. angular/angular-cli#24720
As a result, we can now set the support for running in untrusted
workspaces to "true" since we don't have to execute ngcc from the
`node_modules` folder.
@atscott atscott mentioned this pull request Feb 15, 2023
Merged
atscott added a commit to atscott/vscode-ng-language-service that referenced this pull request Feb 15, 2023
@atscott
refactor: Remove ngcc from extension
7fc6f62 
NGCC is being removed in Angular v16. The language service should not
longer attempt to run it. angular/angular-cli#24720
As a result, we can now set the support for running in untrusted
workspaces to "true" since we don't have to execute ngcc from the
`node_modules` folder.
@ZeroGDrive ZeroGDrive mentioned this pull request Feb 16, 2023
Closed
atscott added a commit to atscott/vscode-ng-language-service that referenced this pull request Feb 16, 2023
@atscott
refactor: Remove ngcc from extension
a991afa 
NGCC is being removed in Angular v16. The language service should not
longer attempt to run it. angular/angular-cli#24720
As a result, we can now set the support for running in untrusted
workspaces to "true" since we don't have to execute ngcc from the
`node_modules` folder.
atscott added a commit to atscott/vscode-ng-language-service that referenced this pull request Feb 17, 2023
@atscott
refactor: Remove ngcc from extension
c0ba555 
NGCC is being removed in Angular v16. The language service should not
longer attempt to run it. angular/angular-cli#24720
As a result, we can now set the support for running in untrusted
workspaces to "true" since we don't have to execute ngcc from the
`node_modules` folder.
atscott added a commit to atscott/vscode-ng-language-service that referenced this pull request Feb 17, 2023
@atscott
refactor: Remove ngcc from extension
edbcbdb 
NGCC is being removed in Angular v16. The language service should not
longer attempt to run it. angular/angular-cli#24720
As a result, we can now set the support for running in untrusted
workspaces to "true" since we don't have to execute ngcc from the
`node_modules` folder.
atscott added a commit to atscott/vscode-ng-language-service that referenced this pull request Feb 23, 2023
@atscott
refactor: Remove ngcc from extension
a507cad 
NGCC is being removed in Angular v16. The language service should not
longer attempt to run it. angular/angular-cli#24720
As a result, we can now set the support for running in untrusted
workspaces to "true" since we don't have to execute ngcc from the
`node_modules` folder.
@Lms24 Lms24 mentioned this pull request Feb 23, 2023
Merged
atscott added a commit to angular/vscode-ng-language-service that referenced this pull request Feb 23, 2023
@atscott
refactor: Remove ngcc from extension
9f6d76c 
NGCC is being removed in Angular v16. The language service should not
longer attempt to run it. angular/angular-cli#24720
As a result, we can now set the support for running in untrusted
workspaces to "true" since we don't have to execute ngcc from the
`node_modules` folder.
@iKrishnaSahu iKrishnaSahu mentioned this pull request Feb 24, 2023
Open
Lms24 added a commit to getsentry/sentry-javascript that referenced this pull request Feb 27, 2023
@Lms24
feat(angular): Add Ivy-compatible Angular SDK package (#7264)
cca2514 
Add a new SDK package to our monorepo: `@sentry/angular-ivy`. 

While this is technically a new SDK, its content and functionality is identical to `@sentry/angular`. Only the build configuration differs:

* The Ivy SDK is built with Angular 12, allowing for a compatibility of NG12-15
* The Ivy SDK is built with `compilationMode: partial`, enabeling a build format that is compatible with Angular's Ivy rendering engine. 
  * This means that `ngcc` no longer needs to step in at initial build time to up-compile the SDK. Which is good because `ngcc` will be removed in Angular 16 (angular/angular-cli#24720)
* The Ivy SDK's build output follows the Angular Package Format (APF) v12 standard ([spec](https://docs.google.com/document/d/1CZC2rcpxffTDfRDs6p1cfbmKNLA6x5O-NtkJglDaBVs/preview)) which is very similar to APF 10 which we used before (see #4641 for more details)

Because functionality-wise there's no difference to `@sentry/angular`, I opted to symlink the source files instead of duplicating them. The only exception is `sdk.ts` which needed some adaption for the new package, like setting the SDK name and adjusting the min version check. For the same reason, this new package currently doesn't contain tests. We'll need to reconsider this approach (symlinking and testing) if we ever need to make package-specific adjustments.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxhub alxhub alxhub approved these changes

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alan-agius4 @alxhub @clydin