Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat@angular-devkit/build-angular: allow TS config files for tailwindcss #24954

Closed
wants to merge 1 commit into from

Conversation

burner-account
Copy link

as mostly the filepath is passed around and handed off to tailwindcss, this might work

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Issue Number: #24943

What is the new behavior?

The behavior is unchanged, only now one more value "tailwind.config.ts" is deemed valid to pass through to tailwindcss.
(see ./packages/angular_devkit/build_angular/src/builders/browser-esbuild/css-plugin.ts)

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

as mostly the filepath is passed around and handed off to tailwindcss, this might work
@google-cla
Copy link

google-cla bot commented Apr 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@burner-account
Copy link
Author

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

I will not sign up with google to fill out a CLA. If there is an option to sign the CLA without creating a google account, please be so kind and let me know.

@burner-account burner-account changed the title feat @angular-devkit/build-angular: allow TS config files for tailwindcss feat@angular-devkit/build-angular: allow TS config files for tailwindcss Apr 4, 2023
@alan-agius4 alan-agius4 requested a review from clydin April 4, 2023 20:47
@alan-agius4
Copy link
Collaborator

@burner-account, thanks for your contribution but a Google account is required to sign the CLA.

Closing since your are not willing to create a Google account.

@alan-agius4 alan-agius4 closed this Apr 4, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants