Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(@angular-devkit/build-angular): enable additional styles tests for esbuild builder #24982

Merged
merged 1 commit into from Apr 11, 2023
Merged

test(@angular-devkit/build-angular): enable additional styles tests for esbuild builder #24982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 3 additions & 6 deletions ...es/angular_devkit/build_angular/src/builders/browser-esbuild/tests/options/styles_spec.ts
View file
Open in desktop
Expand Up @@ -129,8 +129,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => {
harness.expectFile('dist/styles.css').toNotExist();
});

// TODO: Re-enable once output logging is implemented for esbuild builder
xit('shows the output style as a chunk entry in the logging output', async () => {
it('shows the output style as a chunk entry in the logging output', async () => {
await harness.writeFile('src/test-style-a.css', '.test-a {color: red}');

harness.useTarget('build', {
Expand Down Expand Up @@ -401,8 +400,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => {
.content.not.toContain('<link rel="stylesheet" href="extra.css">');
});

// TODO: Re-enable once output logging is implemented for esbuild builder
xit('shows the output style as a chunk entry in the logging output', async () => {
it('shows the output style as a chunk entry in the logging output', async () => {
await harness.writeFile('src/test-style-a.css', '.test-a {color: red}');

harness.useTarget('build', {
Expand All @@ -419,8 +417,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => {
);
});

// TODO: Re-enable once output logging is implemented for esbuild builder
xit('shows the output style as a chunk entry with bundleName in the logging output', async () => {
it('shows the output style as a chunk entry with bundleName in the logging output', async () => {
await harness.writeFile('src/test-style-a.css', '.test-a {color: red}');

harness.useTarget('build', {
Expand Down