fix(@angular-devkit/build-angular): display warning when preserveWhitespaces in set in the tsconfig provided to the server builder
#25038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: rc
alan-agius4
force-pushed
the
preserveWhitespaces-warning
branch
from
41ced95
to
616b737
Compare
clydin
approved these changes
Apr 19, 2023
jessicajaniuk
approved these changes
Apr 19, 2023
packages/angular_devkit/build_angular/src/builders/server/index.ts
Outdated
Show resolved
Hide resolved
alan-agius4
force-pushed
the
preserveWhitespaces-warning
branch
from
616b737
to
3aad92d
Compare
AndrewKushnir
approved these changes
Apr 19, 2023
…tespaces` is set in the tsconfig provided to the server builder This commits add a check to display a warning when `preserveWhitespaces` is configured in `tsconfig.server.json`, as potentially this could cause issue with hydration.
alan-agius4
force-pushed
the
preserveWhitespaces-warning
branch
from
3aad92d
to
29e9de2
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits add a check to display a warning when
preserveWhitespacesis configured intsconfig.server.json, as potentially this could cause issue with hydration.