Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: partially move E2E tests to GHA #25617

Merged
merged 1 commit into from Aug 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 1 addition & 26 deletions .circleci/dynamic_config.yml
Expand Up @@ -321,31 +321,6 @@ workflows:
requires:
- setup

- e2e-tests:
name: e2e-cli-<< matrix.subset >>
nodeversion: *default_nodeversion_major
matrix:
parameters:
subset: *all_e2e_subsets
filters:
branches:
ignore:
- main
- /\d+\.\d+\.x/
requires:
- build

- e2e-tests:
name: e2e-cli-node-<<matrix.nodeversion>>-<< matrix.subset >>
matrix:
alias: e2e-cli
parameters:
nodeversion: *all_nodeversion_major
subset: *all_e2e_subsets
requires:
- build
<<: *only_release_branches

- e2e-tests:
name: e2e-snapshots-<< matrix.subset >>
nodeversion: *default_nodeversion_major
Expand Down Expand Up @@ -380,4 +355,4 @@ workflows:
<<: *only_builds_branches
requires:
- setup
- e2e-cli
- e2e-cli-win
25 changes: 25 additions & 0 deletions .github/workflows/ci.yml
Expand Up @@ -100,3 +100,28 @@ jobs:
- if: matrix.version != env.defaultVersion
name: Run tests for non-default node version
run: yarn bazel test --test_tag_filters=node18,-node18-broken //packages/...

e2e:
strategy:
matrix:
os: [ubuntu-latest]
node: [16, 18]
subset: [npm, yarn, esbuild]
shard: [0, 1, 2, 3]
exclude:
# Exclude Node.js v16 when running on a PR
- node: ${{ github.event_name != 'pull_request' && 'none' || '16' }}
runs-on: ${{ matrix.os }}
steps:
- name: Initialize environment
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@0109d498b0f6aae418ed4924a5e5c65695f0ac61
with:
fetch-depth: 1
- name: Install node modules
run: yarn install --frozen-lockfile
- name: Setup Bazel
uses: angular/dev-infra/github-actions/bazel/setup@0109d498b0f6aae418ed4924a5e5c65695f0ac61
- name: Setup Bazel RBE
uses: angular/dev-infra/github-actions/bazel/configure-remote@0109d498b0f6aae418ed4924a5e5c65695f0ac61
- name: Run CLI E2E tests
run: yarn bazel test --define=E2E_SHARD_TOTAL=4 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}